Skip to content

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 20, 2023

r? cuviper

cuviper and others added 3 commits May 19, 2023 17:01
When we're adding a method to a type DIE, we only want a DW_AT_declaration
there, because LLVM LTO can't unify type definitions when a child DIE is a
full subprogram definition. Now the subprogram definition gets added at the
CU level with a specification link back to the abstract declaration.

(cherry picked from commit 10b69dd)
@rustbot
Copy link
Collaborator

rustbot commented May 20, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2023
@cuviper
Copy link
Member Author

cuviper commented May 20, 2023

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented May 20, 2023

📌 Commit 7a0af09 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2023
@bors
Copy link
Collaborator

bors commented May 20, 2023

⌛ Testing commit 7a0af09 with merge 16ec1c0...

@bors
Copy link
Collaborator

bors commented May 20, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 16ec1c0 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2023
@bors bors merged commit 16ec1c0 into rust-lang:beta May 20, 2023
@rustbot rustbot added this to the 1.70.0 milestone May 20, 2023
@cuviper cuviper deleted the beta-next branch May 21, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants